aws / aws/git-remote-codecommit

Indentation bug - Python

Open
#12 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
289
Forks
40
PR merge metrics
No merged PRs in 30d

Description

I pushed a python script to Code-commit and made a PR. Reviewers saw my code with an error in the last line, the indentation. So when I check my code it was fine, the problem was the indentation on the EOF they were watching on the PR. Let me explain this with an example:
```python
# What you passed to code-commit
for i in table_:
if i:
a='hello'
else:
a='bye' # EOF
```

```python
## What code-commit show you
for i in table_:
if i:
a='hello'
else:
a='bye' # codecommit EOF
```
The short way solution was pushing code with this "uncomfortable" enter in eof:
```python
## What code-commit show you
for i in table_:
if i:
a='hello'
else:
a='bye'
# new EOF
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.