[aws-cloudwatch-metrics] Remove /var/run/docker.sock
- Dominant language
- Mustache
- Stars
- 1.3k
- Forks
- 1.1k
- Avg merge
- 22m
- Merged PRs (30d)
- 5
Description
**Is your feature request related to a problem?**
Amazon EKS now supports Kubernetes 1.24, which removes dockershim; it's my understanding that we'll need to remove the `/var/run/docker.sock` [mount](https://github.com/aws/eks-charts/blob/master/stable/aws-cloudwatch-metrics/templates/daemonset.yaml#L69) (does this also apply to the `/var/lib/docker` [mount](https://github.com/aws/eks-charts/blob/master/stable/aws-cloudwatch-metrics/templates/daemonset.yaml#L72))? However, I'm not sure what the implications of this change would be.
https://aws.amazon.com/blogs/containers/amazon-eks-now-supports-kubernetes-version-1-24/
**Is your feature request related to a specific Helm chart, if yes mention name of the chart?**
aws-cloudwatch-metrics
**Describe the solution you'd like**
Would like the appropriate changes made to the chart to support Amazon EKS with Kubernetes 1.24.
**Describe alternatives you've considered**
I understand that I could fork the chart and make the appropriate changes myself, but I think an upstream approach would be better, additionally, I'm not sure I have the required knowledge to make and test the changes...
Contributor guide
Research direction
Start with stable/aws-cloudwatch-metrics/templates/daemonset.yaml, especially the /var/run/docker.sock mount at line 69 and /var/lib/docker mount at line 72. Read the linked EKS Kubernetes 1.24 announcement and inspect how the chart uses these mounts. Done means the chart's appropriate mounts and related behavior support EKS 1.24 without breaking existing deployments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, docker, helm, kubernetes
- Domain
- cloud, devops
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100