aws / aws/eks-charts

Upgrade CRDs to apiextensions.k8s.io/v1

Open
#560 0 comments 7 reactions 0 assignees View on GitHub
enhancement
Dominant language
Mustache
Stars
1.3k
Forks
1.1k
Avg merge
22m
Merged PRs (30d)
5

Description

**Is your feature request related to a problem?**
When deploying the CRDs using this command (from [Installing the chart](https://github.com/aws/eks-charts/tree/master/stable/appmesh-controller#installing-the-chart)):

kubectl apply -k "github.com/aws/eks-charts/stable/appmesh-controller//crds?ref=master"

I get the following warning:

W0719 13:06:33.130081 56372 warnings.go:70] apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition

**Is your feature request related to a specific Helm chart, if yes mention name of the chart?**
appmesh-controller

**Describe the solution you'd like**
Vend the (kubernetes version appropriate) CRD when called for different versioned clusters.

**Cluster Info**

Server Version: version.Info{Major:"1", Minor:"20+", GitVersion:"v1.20.4-eks-6b7464",
GitCommit:"6b746440c04cb81db4426842b4ae65c3f7035e53", GitTreeState:"clean", BuildDate:"2021-03-19T19:33:03Z",
GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}

Contributor guide

Open the contributing guide

Research direction

Start with the stable/appmesh-controller/crds path referenced by the installation command and inspect how the Helm chart currently vendors its CRDs. Check the Kubernetes API-version requirements for the supported cluster versions; done means appmesh-controller installation selects a compatible CRD version without the apiextensions.k8s.io/v1beta1 deprecation warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
devops, infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.