Update remaining DockerHub-hosted repositories to use ECR
- Dominant language
- Mustache
- Stars
- 1.3k
- Forks
- 1.1k
- Avg merge
- 22m
- Merged PRs (30d)
- 5
Description
tl;dr: Please update `amazon/foo` registry values in these charts to use Amazon-hosted ECR versions of the same.
Per the [Coming Soon blogpost](https://aws.amazon.com/blogs/containers/advice-for-customers-dealing-with-docker-hub-rate-limits-and-a-coming-soon-announcement/) for the AWS public registry:
> All EKS add-on software that is included with EKS clusters is hosted on ECR today and will not be subject to Docker Hub rate limits. EKS-built and maintained projects, such as the AWS Load Balancer Controller include helm charts that reference images on ECR as well. However, manifests for these projects available on GitHub include references to images that are published to Docker Hub. You can check whether you are using a manifest with a Docker Hub image using the steps described in this blog and update to use a chart that references an ECR hosted image. These charts are available in the [EKS Charts](https://github.com/aws/eks-charts) GitHub repository.
We went to update our `aws-node-termination-handler` to use this chart after getting DockerHub pull failures, but it doesn't look like it's going to make a difference:
https://github.com/aws/eks-charts/blob/d721c97c339c8b1060ac8b76a247ce67a470e90c/stable/aws-node-termination-handler/values.yaml#L6
There are several other places that would be subject to the same throttling:
```
stable/appmesh-controller/values.yaml:45: repository: amazon/aws-xray-daemon
stable/aws-cloudwatch-metrics/values.yaml:2: repository: amazon/cloudwatch-agent
stable/aws-for-fluent-bit/values.yaml:6: repository: amazon/aws-for-fluent-bit
stable/aws-node-termination-handler/values.yaml:6: repository: amazon/aws-node-termination-handler
```
And several public images that might need to be replicated as well, either as part of the deployment or as part of CI:
```
stable/appmesh-controller/ci/values.yaml:7: repository: fawadkhaliq/appmesh-controller
stable/appmesh-gateway/ci/values.yaml:5: repository: envoyproxy/envoy
stable/appmesh-grafana/values.yaml:8: repository: grafana/grafana
stable/appmesh-inject/ci/values.yaml:5: repository: stefanprodan/aws-app-mesh-inject
stable/appmesh-jaeger/values.yaml:8: repository: jaegertracing/all-in-one
stable/appmesh-prometheus/values.yaml:11: repository: prom/prometheus
stable/aws-load-balancer-controller/ci/values.yaml:5: repository: kishorj/aws-load-balancer-controller
```
Please update the remaining `amazon/*` images (at least) to use an AWS ECR repository value instead of relying on the current DockerHub repo.
Contributor guide
Assessment
This issue has not been assessed yet.