aws / aws/eks-charts

[aws-load-balancer-controller] How does certificate management work with cert-manager.

Open
#1,308 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Mustache
Stars
1.3k
Forks
1.1k
Avg merge
22m
Merged PRs (30d)
5

Description

Hello! I recently ran into an issue around certificate generation for the webhook and I want to learn more about component of it I dont fully understand.

The issue:
When trying to deploy the aws-load-balancer-controller in a FIPS 140 compliant environment, it cannot generate with genCA due to the presence of SHA-1 as an import in the function (https://github.com/Masterminds/sprig/blob/989da45d7c082c6ec85cf95f59e23b461cdafe03/crypto.go#L15)

To remedy this, I saw the certificate creation can be managed by cert-manager instead which might be more compliant. As I look as the _helpers.tpl (https://github.com/aws/eks-charts/blob/8ed2cf41de403eb6994a5b2df70f97406f985a8d/stable/aws-load-balancer-controller/templates/_helpers.tpl#L95), I dont see a branch where cert-manager can be used to achieve this.

If `enableCertManager` is set to true, the branch still calls genCA.

Now, I want to know a few things:
- Is `enableCertManager=true` not meant to open a path where certificates are created by it or am I meant to add some override to achieve this ?
- On another note, are there better options to have the cert created in a FIPS 140 compliant environment ?

Contributor guide

Open the contributing guide

Research direction

Start with stable/aws-load-balancer-controller/templates/_helpers.tpl at the cited certificate-generation logic, and compare the enableCertManager=true branch with the referenced Sprig crypto.go genCA implementation. Determine whether the flag is intended to delegate certificate creation to cert-manager or needs an override, then document the supported FIPS-compliant path and how it can be verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, helm, kubernetes
Domain
cloud, devops, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.