aws / aws/eks-charts

User Configure initContainers.pullPolicy, init.image.pullPolicy, and nodeAgent.image.pullPolicy not being respect

Open
#1,147 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Mustache
Stars
1.3k
Forks
1.1k
Avg merge
22m
Merged PRs (30d)
5

Description

**Describe the bug**
We have noticed three instances of incorrect helming in some of your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from https://github.com/aquasecurity/trivy-operator/issues/729 regarding the incorrect helming defect.

[initContainers.pullPolicy](https://github.com/aws/eks-charts/blob/e71a947195425d056a88ad09d4cc687ccf129348/stable/appmesh-spire-agent/values.yaml#L31) does not take effect when changed to a value other than default value 'IfNotPresent'. This is due to missing implementation for this value in appmesh-spire-agent/templates/deployment.yaml file:
https://github.com/aws/eks-charts/blob/e71a947195425d056a88ad09d4cc687ccf129348/stable/appmesh-spire-agent/templates/deployment.yaml#L23-L27

[init.image.pullPolicy](https://github.com/aws/eks-charts/blob/e71a947195425d056a88ad09d4cc687ccf129348/stable/aws-vpc-cni/values.yaml#L16), and [nodeAgent.image.pullPolicy](https://github.com/aws/eks-charts/blob/e71a947195425d056a88ad09d4cc687ccf129348/stable/aws-vpc-cni/values.yaml#L35) does not take effect when changed to a value other than default value 'Always'. This is due to missing implementation for this value in aws-vpc-cni/templates/daemonset.yaml file:

https://github.com/aws/eks-charts/blob/e4314638adff3477b3498f5c8e108b577412597f/stable/aws-vpc-cni/templates/daemonset.yaml#L41-L43

https://github.com/aws/eks-charts/blob/e4314638adff3477b3498f5c8e108b577412597f/stable/aws-vpc-cni/templates/daemonset.yaml#L124-L125

**Steps to reproduce**
modify these values in values.yaml file, then deploy them.
**Expected outcome**
The changes for image pull policy should be respected.

**Environment**

* Chart name: appmesh-spire-agent, and 12597f/stable/aws-vpc-cni
* Chart version: main version
* Kubernetes version:
* Using EKS (yes/no), if so version?

**Additional Context**:

Contributor guide

Open the contributing guide

Research direction

Start with stable/appmesh-spire-agent/values.yaml and templates/deployment.yaml, then inspect stable/aws-vpc-cni/values.yaml and templates/daemonset.yaml at the linked lines. Render both charts with non-default pull-policy values, or deploy them as described, and verify the generated init-container and node-agent image fields use those values.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.