aws / aws/eks-charts

Allow configuration of webhook selectors

Open
#1,063 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Mustache
Stars
1.3k
Forks
1.1k
Avg merge
22m
Merged PRs (30d)
5

Description

**Is your feature request related to a problem?**

When standing up a new cluster provisioned by ArgoCD, there's a fairly high (~20% at least) chance that the `mservice.elbv2.k8s.aws` MHW, in a yet-non-functional state will block creation of Linkerd service objects, which in turn will block AWS LBC pods from being created, thus creating a deadlock.

**Describe the solution you'd like**
Fully configurable `objectSelector` blocks in webhookconfiguration should allow excluding certain services from the webhook.

**Describe alternatives you've considered**
Configuring linkerd MWH to exclude objects labeled with `app.kubernetes.io/name: aws-load-balancer-controller`. This worked, FWIW, but only because Linkerd's MHW configuration [**does allow**](https://github.com/linkerd/linkerd2/blob/5aef29ace1294170009746186c3dbd4a5563a5f4/charts/linkerd-control-plane/templates/proxy-injector-rbac.yaml#L97-L102) the very customization I'm requesting here. This may not be the case for other webhooks myself or other people encounter in tandem with AWS LBC.

Contributor guide

Open the contributing guide

Research direction

Locate the Helm chart templates that render webhookconfiguration resources and the values used to configure them. Read how existing webhook fields are exposed, then verify that objectSelector blocks can be supplied for the relevant webhooks without changing defaults. Done means chart users can exclude selected services through configuration and the rendered webhook configuration contains the requested selectors.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, helm, kubernetes
Domain
devops, infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.