Missing "imagePullSecrets" field in Cloudwatch metrics helm templates definition (daemonset.yaml)
- Dominant language
- Mustache
- Stars
- 1.3k
- Forks
- 1.1k
- Avg merge
- 22m
- Merged PRs (30d)
- 5
Description
**Describe the bug**
imagePullSecrets field is missing in daemonset.yaml in https://github.com/aws/eks-charts/blob/master/stable/aws-cloudwatch-metrics/templates/daemonset.yaml. Due to this its not able to download private images stored in private registry. In order to fix, these chats has to be managed in private repo so cannot utilise as it it from public repo.
**Steps to reproduce**
There is definition missing for imagePullSecret in manifest daemonset.yaml in helm chart templates.
**Expected outcome**
Download the chart and update the field of imagePullSecret and pushed the helm chart to private helm repo and using this installed the helm chart for aws-cloudwatch-metrics with imagepullsecret value. It should work fine
**Environment**
Production
* Chart name: aws-cloudwatch-metrics
* Chart version: 0.0.9 and 0.0.7
* Kubernetes version: 1.25
* Using EKS (yes/no), if so version? Yes
**Additional Context**: Have also raised the PR request for this. https://github.com/aws/eks-charts/pull/1010
Contributor guide
Research direction
Review PR #1010 first, then inspect stable/aws-cloudwatch-metrics/templates/daemonset.yaml and the chart's imagePullSecrets values. Render the aws-cloudwatch-metrics chart with imagePullSecrets configured and verify that the generated DaemonSet includes the field so private images can be pulled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100