aws / aws/eks-anywhere

Executable Helm method updates the receiver and is not thread safe

Open
#7,176 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
2.1k
Forks
328
Avg merge
1d 4h
Merged PRs (30d)
9

Description

We found that a method in the executables.Helm struct is updating the receiver. This is not thread safe, and we should change it:

https://github.com/aws/eks-anywhere/blob/380588591eb2777b3fc8e6d25f315c8b8d12fdcc/pkg/executables/helm.go#L238

Contributor guide

Open the contributing guide

Research direction

Inspect pkg/executables/helm.go around line 238 and trace how the Helm method updates its receiver. Check nearby tests for executable behavior, then verify that concurrent calls no longer share mutable receiver state and run the relevant Go tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, helm
Domain
devops, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.