aws / aws/eks-anywhere

Provider-specific WithKubeVersionAndOS methods in tests shouldn't require release by default

Open
#6,311 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
2.1k
Forks
328
Avg merge
1d 4h
Merged PRs (30d)
9

Description

Each Provider defined in the E2E test framework implements a `WithKubeVersionAndOS` method that configures the cluster config to use a specific template or image based on OS and Kubeversion, and configure the osFamily in the machine configs. As the method name suggests, the inputs to this method are the Kubernetes version and Operating system, while defaulting to the dev release bundle for EKS-D name, since a majority of these tests run the latest CLI from main.

In #6284, the function signature for this method was changed to include a mandatory release argument that will be used for a nil check to determine whether to use the dev release or the provided one. This means almost all the non-LatestMinorRelease tests that use this method should now include an explicit nil parameter. Instead we should add a separate method for the non-default release case, while keeping the default `WithKubeVersionAndOS` method accept just the relevant parameters.

Contributor guide

Open the contributing guide

Research direction

Start in the E2E test framework by locating the Provider implementations of WithKubeVersionAndOS and their callers, especially non-LatestMinorRelease tests. Compare the default and explicit-release call paths, then update the method usage consistently and verify the E2E test framework builds and affected tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.