aws / aws/eks-anywhere

Remove skip for crypto unit test in darwin

Open
#3,267 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
2.1k
Forks
328
Avg merge
1d 4h
Merged PRs (30d)
9

Description

We want to undo https://github.com/aws/eks-anywhere/pull/3262 as soon as Go makes the appropriate fix here https://github.com/golang/go/issues/52010. Currently slated for `1.20` release, so when we upgrade to that version we should be able to verify if the same type is returned as for linux.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing pull request #3262 and the linked Go issue #52010 to understand the Darwin crypto test workaround. Locate the skipped unit test, then verify it with the Go 1.20 upgrade on Darwin and Linux; done means the skip can be removed and both platforms return the same type.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
operating-systems, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.