aws / aws/eks-anywhere

Refactor Git provider validations out of dependency factory

Open
#1,982 0 comments 1 reaction 0 assignees View on GitHub
area/gitops kind/enhancement team/cli
Dominant language
Go
Stars
2.1k
Forks
328
Avg merge
1d 4h
Merged PRs (30d)
9

Description

We currently have Git provider validations in the `WithGit` function, but we should only be validating on the build itself and not the validations. We should move this over to a separate place where we perform these validations before cluster operations, but after we build the dependencies, potentially in the validations package.

https://github.com/aws/eks-anywhere/blob/main/pkg/dependencies/factory.go#L756-L767

Contributor guide

Open the contributing guide

Research direction

Start by reading pkg/dependencies/factory.go around lines 756-767 and tracing the validations package and dependency build flow. Run the relevant package tests to understand the current behavior. Done means Git provider checks no longer run in WithGit, but run before cluster operations after dependencies are built.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
infrastructure
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.