Investigate need for checking taints/labels for new worker node template
- Dominant language
- Go
- Stars
- 2.1k
- Forks
- 328
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 9
Description
We currently have this check which forces rollout of worker nodes instead of only applying on new nodes if there are changes to the kubeadmconfigtemplate, but we need to confirm this is the behavior and whether we can call the `NeedsNewKubeadmConfigTemplate` from the `NeedsNewWorkloadTemplate`method instead of having two different checks for this.
https://github.com/aws/eks-anywhere/blob/v0.8.2/pkg/providers/vsphere/vsphere.go#L515-L518
Contributor guide
Research direction
Start at pkg/providers/vsphere/vsphere.go lines 515-518 and trace the existing check that forces worker-node rollout after KubeadmConfigTemplate changes. Read the NeedsNewKubeadmConfigTemplate and NeedsNewWorkloadTemplate methods to confirm the current behavior and determine whether one can call the other. Done means the behavior is confirmed and the checks are consolidated only if that is safe.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100