Etcdadm controller enhancement: Change how ready condition and field gets set
- Dominant language
- Go
- Stars
- 2.1k
- Forks
- 328
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 9
Description
Potential changes based on this review comment from @g-gaston : https://github.com/mrajashree/etcdadm-controller/pull/14#discussion_r820172039 (need to test & evaluate both)
- [ ] Currently the EtcdMachinesReady condition is an aggregate of the Ready conditions of all existing machines. Consider making this an aggregate of all machines the cluster is supposed to own. (Need to test this out before deciding to make the changes).
- [ ] The status.Ready field gets set to tru as soon as etcd members pass healthcheck. Determine if it makes more sense to set this field based on the value of the Ready condition instead.
Contributor guide
Research direction
Start with the linked pull request discussion and trace the controller code that computes the EtcdMachinesReady condition and status.Ready field. Evaluate both proposed behaviors with the existing controller tests or add coverage where needed; done means the chosen semantics are implemented and verified, with the decision documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- infrastructure
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100