aws / aws/containers-roadmap

[EKS] [request]: provide taints and labels for managed nodes from the start

Open
#1,962 6 comments 18 reactions 0 assignees View on GitHub
EKS EKS Managed Nodes Proposed
Dominant language
Shell
Stars
5.4k
Forks
334
PR merge metrics
No merged PRs in 30d

Description

### Community Note

* Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request
* Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
* If you are interested in working on this issue or have submitted a pull request, please leave a comment

**Tell us about your request**
provide taints and labels from the beginning of a nodes lifecycle, as if they had been on the kubelet command line

**Which service(s) is this request for?**
EKS

**Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?**
We switched to providing taints and labels via the managed node group after this feature was added in #917.
It appears that taints and labels are only applied around half a minute after the node joins the cluster. This has multiple undesirable side effect.

* when adding capacity from different node groups for different workloads the scheduler places indifferent pods to nodes that later get taints instead of our catch-all node group.
* the late addition of labels breaks the display of pricing information in the eks-node-viewer for managed nodes, see https://github.com/awslabs/eks-node-viewer/issues/36

**Are you currently working around this issue?**
Not at all.
Possible workaround are:
* falling back to specifying labels and taints on the kubelet command line
* adding a descheduler to all clusters

**Additional context**
Due to the different way of Karpenter to bring up nodes its working as expected with it.
Tested with EKS managed node groups version 1.23 platform version eks.6

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the managed node group behavior described here and the prior feature in issue #917. Compare how EKS managed node groups apply taints and labels with kubelet command-line configuration and the Karpenter behavior mentioned in the issue. Done means taints and labels are present from node startup, before scheduling and pricing discovery occur.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, kubernetes
Domain
cloud, infrastructure
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.