aws / aws/codecatalyst-blueprints

Under the hood string replacements of characters are not transparent and not validated

Open
#478 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
58
Forks
22
Avg merge
19m
Merged PRs (30d)
1

Description

There are a few `.replace` parts of the Blueprints SDK that are not transparent...
see here:
https://github.com/search?q=repo%3Aaws%2Fcodecatalyst-blueprints+.replace&type=code

And example is if you name and action `my-action` and then want to do a `.dependsOn` on it you need to know that it will need to be named `my_action` in the workflow

This is not really cool - at least somehow every `.replace` like this should force a warning in the log or potentially maybe even.... a failure?

Contributor guide

Open the contributing guide

Research direction

Start with the repository-wide `.replace` search linked in the issue and trace the replacements involved in workflow names and `.dependsOn`. Document each affected transformation, then verify that invalid or non-transparent character changes produce the requested warning or failure and that the `my-action`/`my_action` case is covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.