aws / aws/chalice

Deployment proceeds despite packaging failures

Open
#929 3 comments 2 reactions 0 assignees View on GitHub
feature-request
Dominant language
Python
Stars
11.1k
Forks
1k
Avg merge
1d 22h
Merged PRs (30d)
2

Description

The `LambdaDeploymentPackager` prints a failure message when trying to build dependencies [here](https://github.com/aws/chalice/blob/master/chalice/deploy/packager.py#L88), but otherwise proceeds with deploying a (likely broken) Lambda function.

This is a bit cumbersome in a deployment toolchain as my deploy step currently succeeds and smoke-tests then fail. Is there a recommended way to have Chalice error out when packaging fails? I'm happy to send a PR for a `--strict` or `--abort-when-packaging-incomplete` packaging mode of some sort :)

See also #928.

Contributor guide

Open the contributing guide

Research direction

Start in chalice/deploy/packager.py at the LambdaDeploymentPackager failure path around line 88, then trace how deployment handles that result. Review #928 for related context. Done means packaging failure causes the requested strict or abort behavior and the deploy step reports failure instead of proceeding.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, python
Domain
cloud, devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.