aws / aws/aws-xray-sdk-python

Validate annotation key-value type

Open
#268 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
338
Forks
147
PR merge metrics
No merged PRs in 30d

Description

As per [document](https://docs.aws.amazon.com/xray/latest/devguide/xray-sdk-python-segment.html) X-Ray SDK accepts key-value pairs with string, number, or Boolean values for annotations. Now, in the case of customer adding key-value pairs other than these 3 supported data types SDK silently accepts other type and fail to add annotations which is undesired behavior. Instead, SDK should throw the error in the case of unaccepted types.

Solution: We probably can add a check to validate if data type is string, number, or Boolean

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.