aws / aws/aws-xray-sdk-python

No way to avoid loading the sampling_rule.json file

Open
#108 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
338
Forks
147
PR merge metrics
No merged PRs in 30d

Description

Would it be possible to only load this file if the LocalSampler is initialized?

Moving

`with open(resource_filename(__name__, 'sampling_rule.json')) as f:
local_sampling_rule = json.load(f)
`
to `def __init__(self, rules=local_sampling_rule):`

_Originally posted by @christianbeland in https://github.com/aws/aws-xray-sdk-python/issues/105#issuecomment-428700941_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.