aws / aws/aws-xray-sdk-node

Feature Request: Capturing additional SQL Query information

Open
#9 7 comments 4 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
280
Forks
157
PR merge metrics
No merged PRs in 30d

Description

The current MySQL instrumentation only captures the url and query type of each query made.

It would be nice to update the instrumentation to also capture the actual query being run.

Obviously there would be privacy concerns attached to this, since you probably don't want to log out every query.

I'm happy to implement this if I can get some direction from the core team as to how you want to handle this.

I was thinking you can provide a predicate as part of the options initialising the instrumentation. This predicate that would be given the query being run, and return whether or not this query should log the query being run.

I came to look for this after seeing this forum thread: https://forums.aws.amazon.com/thread.jspa?messageID=809685

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.