aws / aws/aws-xray-sdk-node

Postgres queries fail when using `Submittable` interface

Open
#349 5 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
280
Forks
157
PR merge metrics
No merged PRs in 30d

Description

When capturing postgres is enabled queries made with the `Submittable` interface cause a TypeError indicating

> Client was passed a null or undefined query at Client.query

This makes it so the postgres capture does not work with [pg-cursor](https://github.com/brianc/node-postgres/tree/master/packages/pg-cursor) or [pg-query-stream](https://github.com/brianc/node-postgres/tree/master/packages/pg-query-stream).

Contributor guide

Open the contributing guide

Research direction

The issue concerns PostgreSQL capture around Client.query; start by reproducing it with the Submittable interface, pg-cursor, and pg-query-stream. Done means those queries no longer pass a null or undefined query to Client.query and PostgreSQL capture works.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, postgresql
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.