aws / aws/aws-xray-sdk-node

AWSXRay.config(): confusing calls to segmentUtils.setOrigin() overwrite each other

Open
#290 6 comments 0 reactions 1 assignee Claimed by @willarmiros View on GitHub
enhancement
Dominant language
JavaScript
Stars
280
Forks
157
PR merge metrics
No merged PRs in 30d

Description

https://github.com/aws/aws-xray-sdk-node/blob/6d356678de8d7214ba67a2f37291e71de818e45a/packages/core/lib/aws-xray.js#L56-L67

Reading through this I noticed that while each plugin provides an `originName`, and `setOrigin` is called per plugin, the segmentUtils actually only have a single `origin` -- IOW the origin of the last plugin wins. This is a bit confusing/unexpected to me.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.