aws / aws/aws-xray-sdk-node

Centralised Rules with Annotations are Ignored

Open
#232 3 comments 0 reactions 0 assignees View on GitHub
documentation enhancement
Dominant language
JavaScript
Stars
280
Forks
157
PR merge metrics
No merged PRs in 30d

Description

Is this intended? Any rules with annotations are deliberately thrown away.

Presumably the ability to match on annotations is wanted?
https://github.com/aws/aws-xray-sdk-node/blob/8109e1e256288764571bdad45f2100c48280b8c4/packages/core/lib/middleware/sampling/service_connector.js#L115

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.