aws / aws/aws-xray-sdk-java

change attribute key name from "rule_name" to "sampling_rule_name"

Open
#81 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
100
Forks
100
PR merge metrics
No merged PRs in 30d

Description

# Issue
When a sampling rule is recorded on the `Segment`, the current attribute key is [rule_name](https://github.com/aws/aws-xray-sdk-java/blob/4034a834f0c580c9f661d096028f9bc654843aff/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/entities/SegmentImpl.java#L133). The correct key name should be "sampling_rule_name"

# Reference
AWS X-Ray SDK for .NET/Core : [sampling_rule_name](https://github.com/aws/aws-xray-sdk-dotnet/blob/f41ad03fbec63b63a246bf76e4748c5fe346cadf/sdk/src/Core/AWSXRayRecorderImpl.cs#L372)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.