aws / aws/aws-xray-sdk-java

Kinesis errors with AWS SDK 1.X instrumentator

Open
#237 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
100
Forks
100
PR merge metrics
No merged PRs in 30d

Description

I am not sure if it is better with 2.X but I can confirm that it is not working out of the box, that's caused by Kinesis doing calls to DynamoDB in the worker threads before the application has access to the worker thread to create a segment so the context missing error appears.
I was able to work around it with the help of this SO thread: https://stackoverflow.com/questions/49280253/how-can-use-the-java-kinesis-client-library-together-with-x-ray
But I was expecting out of the box support or in the worse case no support, but this situation of not using the instrumentator for the other services to avoid this error is really weird.
I don't have traces at hand to share but should be easy to replicate. If needed I can try to provide you with some.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.