aws / aws/aws-xray-daemon

Fix Log Levels

Open
#95 4 comments 0 reactions 1 assignee Claimed by @bhautikpip View on GitHub
enhancement
Dominant language
Go
Stars
193
Forks
73
Avg merge
2d 7h
Merged PRs (30d)
3

Description

Right now, "prod" log level is set to info: https://github.com/aws/aws-xray-daemon/blob/master/pkg/logger/log_config.go

We should configure it to "Error" level, since we state in the [docs](https://docs.aws.amazon.com/xray/latest/devguide/xray-daemon-configuration.html#xray-daemon-configuration-configfile) that it's the least verbose. This is arguably a breaking change since prod is the default log level, but we can discuss whether that is truly the case given the current behavior is incorrect.

We should also add a "silent" log level that suppresses all log messages.

Related: #62

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.