aws / aws/aws-workload-credentials-provider

refresh_command should not be triggered if "*.crt" file is unchanged, but "*.key" file is missing

Open
#263 0 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
706
Forks
45
Avg merge
3d 1h
Merged PRs (30d)
6

Description

It seems like it would be best practice to delete the "*.key" file after it is processed to help prevent private key abuse.

So when the provider checks if a certificate has been updated, it should only compare the "*.crt" file when considering if an update has occurred. A missing "*.key" file should be tolerated.

Unless I'm misunderstanding the process, when the cert is renewed, its "*.crt" file is going to change. There should be no need to continually expose the private key. At the very least, an option should exist to skip checking the "*.key" file.

Contributor guide

Open the contributing guide

Research direction

No file or test is named in the issue. Start by locating the certificate comparison and refresh_command path; verify that an unchanged *.crt with a missing *.key does not trigger a refresh, while a changed certificate still does.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cloud, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.