aws / aws/aws-toolkit-vscode

tests/CI: failing python integ tests

Open
#2,737 0 comments 0 reactions 0 assignees View on GitHub
tests-ci-cd
Dominant language
TypeScript
Stars
2k
Forks
807
Avg merge
10h 12m
Merged PRs (30d)
7

Description

- failing since https://github.com/aws/aws-toolkit-vscode/commit/3626b1e208c0b41bd22454eb51905d69f403e890
- likely because of an upstream change in...
- ~~python extension~~
- https://github.com/aws/aws-sam-cli-app-templates

```
2 failing
1) SAM Integration Tests
SAM runtime: python3.8 (Image)
Starting from scratch
creates a new SAM Application (happy path):

AssertionError [ERR_ASSERTION]: Expected SAM App readme to exist at /codebuild/output/src048868088/src/github.com/aws/aws-toolkit-vscode/dist/src/testFixtures/workspaceFolder/inttestSTNKPY/python3.8/test-NH5maZ/testProject/README.md
+ expected - actual

-false
+true

at Context. (src/integrationTest/sam.test.ts:465:28)
at Generator.next ()
at fulfilled (dist/src/integrationTest/sam.test.js:9:58)

2) SAM Integration Tests
SAM runtime: python3.8 (Image)
Starting with a newly created python3.8 (Image) SAM Application...
"before all" hook for "produces an error when creating a SAM Application to the same location":

AssertionError [ERR_ASSERTION]: Expected SAM template to exist at /codebuild/output/src048868088/src/github.com/aws/aws-toolkit-vscode/dist/src/testFixtures/workspaceFolder/inttestSTNKPY/python3.8/samapp-dNEUpY/testProject/template.yaml
+ expected - actual

-false
+true

at Context. (src/integrationTest/sam.test.ts:488:28)
at Generator.next ()
at fulfilled (dist/src/integrationTest/sam.test.js:9:58)

Error: 2 tests failed.
```

## Analysis

tested locally:

```
sam init --name testProject --no-interactive --dependency-manager pip --package-type Image --base-image amazon/python3.8-base --app-template hello-world-lambda-image
```

The command succeeds and creates the expected files.

Contributor guide

Open the contributing guide

Research direction

Read src/integrationTest/sam.test.ts around lines 465 and 488, then compare the CI failure with the local sam init command shown. Check the generated fixture paths and upstream SAM CLI or template behavior; done means the Python 3.8 image integration tests pass and the expected README.md and template.yaml assertions succeed.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, python, typescript
Domain
ci-cd, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.