aws / aws/aws-toolkit-vscode

localization: "Message ... didn't get externalized correctly"

Open
#1,774 1 comment 1 reaction 0 assignees View on GitHub
bug localization
Dominant language
TypeScript
Stars
2k
Forks
807
Avg merge
10h 12m
Merged PRs (30d)
7

Description

## Problem

vscode extension host sometimes reports warnings of the form:

> Message ... didn't get externalized correctly.

## Solution?

Haven't confirmed, but based on https://github.com/microsoft/vscode/issues/42426 / https://github.com/microsoft/vscode-node-debug/commit/4d9a3a70fb776e05df218849a68cdfd2645d4ed0 we may need to do:

1. call `nls.loadMessageBundle()` directly in modules instead of using `src/shared/utilities/vsCodeUtils.ts:localize()`
2. remove `src/shared/utilities/vsCodeUtils.ts:localize()`

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the warning in the VS Code extension host, then inspect src/shared/utilities/vsCodeUtils.ts:localize() and the modules that use it. Compare the behavior with microsoft/vscode issue 42426 and the referenced vscode-node-debug commit. Done means the warning no longer appears and messages are externalized correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
developer-experience, localization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.