aws / aws/aws-toolkit-visual-studio

CloudFormation JSON-files use light mode font colors in dark mode

Open
#329 1 comment 1 reaction 0 assignees View on GitHub
bug
Dominant language
No language data
Stars
135
Forks
37
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
Syntax highlighting in CloudFormation JSON files uses light mode colors in dark mode

**To Reproduce**
1. Create a new CloudFormation-file `cfn.template`.
2. Open the file in Visual Studio with **dark mode** enabled
3. Put valid CloudFormation JSON code in the file:
```json
{
"Resources": {
"MyBucket": {
"Type": "AWS::S3::Bucket",
"Properties": {
"BucketName": "my-bucket-name"
}
}
}
}
```
4. Notice how the font is using the colors for light mode, and not the dark mode colors as you would expect.

**Expected behavior**
Syntax should be displayed in dark mode colors

**Screenshots**
The above example in my editor
![image](https://user-images.githubusercontent.com/112705994/227142935-96b8239e-9265-44c5-9723-bff80d8dedf1.png)

There are dark mode colors defined in the options (Tools -> Options -> Environment -> Fonts and colors) that aren't being used. Here you can see that the normal font color is used:
![image](https://user-images.githubusercontent.com/112705994/227143246-28fb5ed7-47ec-420d-b53d-4626b75bdf82.png)

**Computer**
- Windows Version: 10.0.19045 Build 19045
- Visual Studio Version: Visual Studio Professional 2022 (17.5.3)
- AWS Toolkit for Visual Studio Version: 1.39.0.0

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the CloudFormation JSON syntax highlighting in Visual Studio with dark mode enabled, then inspect how the editor applies the defined font and color settings. Done means the sample CloudFormation JSON uses the dark-mode colors instead of the light-mode colors.

Written by the indexing model from the issue text.

Assessment

Tech stack
json
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.