aws / aws/aws-toolkit-azure-devops

CloudFormationCreateOrUpdateStack task doesn't use timeoutInMins parameter

Open
#374 2 comments 1 reaction 0 assignees View on GitHub
bug pending-release
Dominant language
TypeScript
Stars
258
Forks
114
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**

CloudFormationCreateOrUpdateStack has a documented "timeoutInMins" parameter, which is how long it will wait for the stack to reach UPDATE_COMPLETE state.
However, setting this parameter has no effect, it will always wait for a maximum of 60 minutes.
Looking at the code in `/Tasks/CloudFormationCreateOrUpdateStack/TaskParameters.ts`, it seems like `parameters.timeoutInMins` is always set to `defaultTimeoutInMins`, it is never read from the inputs.

**To reproduce**

- Create a CloudFormation template that takes over 1 hour to deploy (in our case, we are updating an RDS cluster based on a large snapshot).
- Create a pipeline to deploy the template using the CloudFormationCreateOrUpdateStack, setting the `timeoutInMins` parameter to `120`.
- Run the pipeline. It will timeout after 60 minutes.

Alternatively, if you set `timeoutInMins` to a very short time, e.g. 2 minutes, it should also continue to run for 60 minutes due to the bug.

**Expected behavior**

The deployment task should complete, or timeout after the set number of minutes.

**Your Environment**

- On-prem or cloud based?: Cloud based
- Azure DevOps version:
- AWS Toolkit for Azure DevOps version: 1.8.0

Contributor guide

Open the contributing guide

Research direction

Start in Tasks/CloudFormationCreateOrUpdateStack/TaskParameters.ts and trace how the timeoutInMins input is populated and passed to the deployment wait. Reproduce the behavior with a short timeout, then confirm that the task completes or times out according to the configured value rather than a fixed 60-minute limit.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, typescript
Domain
cloud, infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.