aws / aws/aws-sdk-java-v2

Add Exception to ApiCallAttempt metrics

Open
#2,485 3 comments 0 reactions 0 assignees View on GitHub
feature-request hacktoberfest p3 sdk-metrics
Dominant language
Java
Stars
2.6k
Forks
1k
Avg merge
2d 9h
Merged PRs (30d)
51

Description

If an SDK calls throws an exception (Http timeout, Resource not found exception), it would be useful to capture that as part of the `ApiCallAttempt` metrics collection.

Especially for an Http timeout, the SDK will make a bunch of attempts but for each attempt it will log only the `SigningDuration` and `BackoffDelayDuration` metric. If we want to investigate what happened to a particularly high latency call, looking at the detailed `ApiCallAttempt` metric would not give us the right hints. But having the Exception instance for each call attempt will be incredibly helpful.

Please consider adding an Exception metric record to the `ApiCallAttempt` metrics - this is currently done in the V1 SDK so should ideally be also made available to the V2 SDK.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.