aws / aws/aws-sdk-java-v2

setting default proxy port from system property differs fromJDK standard

Open
#2,309 1 comment 0 reactions 0 assignees View on GitHub
bug p3 proxy
Dominant language
Java
Stars
2.6k
Forks
1k
Avg merge
2d 9h
Merged PRs (30d)
51

Description

related to / can be clubbed with #1793

## Describe the bug
As per JDK documentation of [networking properties](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/net/doc-files/net-properties.html), if `http.proxyPort` is not set the default port (`80` for http, `443` for https) will be taken.

However the [AWS sdk implementation](https://github.com/aws/aws-sdk-java-v2/blob/16b1f5719bb8966c99c37236a203f8d873f5e586/http-clients/apache-client/src/main/java/software/amazon/awssdk/http/apache/ProxyConfiguration.java#L200) is setting the default to be zero `0`.

PS: current implementation doesn't honor https variants (`https.proxy*`) also.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.