aws / aws/aws-sdk-java-v2

SdkMetricPublisherService to inject metric publishers with ServiceLoader

Open
#2,132 3 comments 0 reactions 0 assignees View on GitHub
feature-request p3
Dominant language
Java
Stars
2.6k
Forks
1k
Avg merge
2d 9h
Merged PRs (30d)
51

Description

In the [metrics design document](https://github.com/aws/aws-sdk-java-v2/blob/master/docs/design/core/metrics/Design.md) 3 options are defined to enable metrics.
Option 1, at request level, and option 2, at client level, are currently available. But [Option 3](https://github.com/aws/aws-sdk-java-v2/blob/master/docs/design/core/metrics/Design.md#option-3-configuring-metricpublishers-using-system-properties-or-environment-variables), to enable it by default everywhere using environment values or system properties, is missing.

The proposal is that if it is enabled in the environment/system properties, a `ServiceLoader` will look for all classes implementing the `SdkMetricPublisherService` and us it to inject `MetricPubliser`s in all clients.
But this is not implemented.

It would be very nice to have this solution, as it would allow us to enable metrics without adapting code.

We are wondering what the status of this option 3 currently is.

Is it still actively worked on? Is it abandoned, and if so why? Or is it just somewhere on the roadmap?

- [x] I may be able to implement this feature request

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.