aws / aws/aws-sdk-cpp

Missing includes

Open
#3,002 10 comments 0 reactions 0 assignees Claimed by @jmklix View on GitHub
bug build-problem p3 pending-release
Dominant language
C++
Stars
2.2k
Forks
1.2k
Avg merge
3d 14h
Merged PRs (30d)
12

Description

### Describe the bug

I am working on bazel build rules for some aws sdk libraries; bazel is more strict about includes than cmake.
These files are missing includes, which causes errors.

* aws-cpp-sdk-core/include/aws/core/NoResult.h
* aws-cpp-sdk-core/include/aws/core/utils/stream/StreamBufProtectedWriter.h
* aws-cpp-sdk-core/include/aws/core/monitoring/MonitoringFactory.h
* aws-cpp-sdk-core/include/aws/core/Globals.h
* aws-cpp-sdk-core/include/aws/core/utils/event/EventStreamEncoder.h

### Expected Behavior

No errors.

### Current Behavior

Errors on missing includes.

### Reproduction Steps

Add BUILD.bazel rules and build.

### Possible Solution

* aws-cpp-sdk-core/include/aws/core/NoResult.h

```
#include
```

* aws-cpp-sdk-core/include/aws/core/utils/stream/StreamBufProtectedWriter.h

```
#include
#include
#include
```

* aws-cpp-sdk-core/include/aws/core/monitoring/MonitoringFactory.h

```
include
```
* aws-cpp-sdk-core/include/aws/core/Globals.h
```
#include
```

* aws-cpp-sdk-core/include/aws/core/utils/event/EventStreamEncoder.h
```
#include
#include
```

### Additional Information/Context

_No response_

### AWS CPP SDK version used

67f1aae9c821f8ed061a89423741a16a4723d018

### Compiler and Version used

clang

### Operating System and version

linux

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.