Fix compiler warnings
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 1.2k
- Avg merge
- 3d 14h
- Merged PRs (30d)
- 12
Description
### Describe the bug
My compiler shows me a bunch of warnings that I'd like to get fixed. This is just a small list:
`aws-cpp-sdk-core/include/aws/core/NoResult.h:29:81: warning: extra ';' after member function definition [-Wextra-semi]`
`/aws-cpp-sdk-core/include/aws/core/AmazonSerializableWebServiceRequest.h:42:17: warning: '~AmazonSerializableWebServiceRequest' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]`
`aws-cpp-sdk-core/include/aws/core/http/HttpResponse.h:115:21: warning: 65 enumeration values not explicitly handled in switch: 'REQUEST_NOT_MADE', 'CONTINUE', 'SWITCHING_PROTOCOLS'... [-Wswitch-enum]`
`aws-crt-cpp/crt/aws-c-io/include/aws/io/socket.h:98:18: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant]`
`aws-crt-cpp/include/aws/crt/StringView.h:534:49: warning: implicit conversion changes signedness: 'unsigned long' to 'const Aws::Crt::basic_string_view::difference_type' (aka 'const long') [-Wsign-conversion]`
`aws-crt-cpp/crt/aws-c-common/include/aws/common/math.gcc_builtin.inl:63:28: warning: implicit conversion changes signedness: 'int64_t' (aka 'long long') to 'unsigned long long' [-Wsign-conversion]`
`aws-crt-cpp/crt/aws-c-common/include/aws/common/math.gcc_builtin.inl:63:12: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]`
### Expected Behavior
I expect the SDK to have 0 warnings.
### Current Behavior
The current behaviour is that there are many warnings.
### Reproduction Steps
I'm compiling a CLion project on MacOS 12.6 with ninja build tool and CMake 3.24.2.
### Possible Solution
_No response_
### Additional Information/Context
_No response_
### AWS CPP SDK version used
1.10.47
### Compiler and Version used
clang 14.0.0
### Operating System and version
MacOS 12.6, CLion 2022.3.2
Contributor guide
Assessment
This issue has not been assessed yet.