aws / aws/aws-sam-cli

[Announcement] Exit Code for sam deploy —on-failure DELETE - SAM CLI

Open
#6,363 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
6.7k
Forks
1.2k
Avg merge
1d 10h
Merged PRs (30d)
52

Description

There is currently a bug with sam deploy when the flag `—on-failure DELETE` is provided, the exit code is 0, regardless of the stack actually being deployed. With the recent change https://github.com/aws/aws-sam-cli/pull/6258, sam deploy will now properly return an appropriate non-zero exit code when deploy fails. This will be implemented in the next release of AWS-SAM-CLI. Please be aware that the change may cause existing code that depends on the exit code of `sam deploy —on-failure DELETE` to fail, requiring updates.

## Does this affect me?
If you have code that depends on the exit code of `sam deploy —on-failure DELETE`, this change will affect you

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.