aws / aws/aws-sam-cli

no-fail-on-empty-changeset parameter not getting saved to samconfig.toml or mapped to deploy

Open
#2,313 4 comments 1 reaction 0 assignees View on GitHub
maintainer/need-followup type/question
Dominant language
Python
Stars
6.7k
Forks
1.2k
Avg merge
1d 10h
Merged PRs (30d)
52

Description

### Description

When passing the --no-fail-on-empty-changeset flag in `sam deploy -g`, the parameter does not get saved to the samconfig.toml file. It also does not get passed in the deploy or have any affect. In #1657 this is talked about and the solution was to manually add it to the template. However, as of v1.6.2 this doesn't seem to work. I tried both `no-fail-on-empty-changeset=true` and `fail-on-empty-changeset=false`. No joy on either options.

### Steps to reproduce
1. in project run `sam deploy -g --no-fail-on-empty-changeset`

### Observed result
```Usage: sam deploy [OPTIONS]
Try 'sam deploy --help' for help.

Error: no such option: --no-fail-on-empty-changese Did you mean --no-fail-on-empty-changeset?
```

### Expected result

I expected the build to work even if no changes were found. I also expected the parameter to be saved in the samconfig.toml file for later builds

### Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

1. OS: Mac and Linux
2. `sam --version`: 1.6.2

`Add --debug flag to command you are running`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.