aws / aws/aws-sam-cli

Global AllowCredentials is not working with localhost / local server

Open
#1,645 8 comments 5 reactions 0 assignees View on GitHub
area/local/start-api maintainer/need-followup
Dominant language
Python
Stars
6.7k
Forks
1.2k
Avg merge
1d 10h
Merged PRs (30d)
52

Description

```
Globals:
Api:
Cors:
AllowOrigin: "'http://localhost:9000'"
AllowCredentials: "'true'"
AllowMethods: "'GET,POST'"
AllowHeaders: "'*'"
```

I have seen this: https://github.com/awslabs/serverless-application-model/issues/1166

But `AllowCredentials` is definitely not working for either `true`, `"true"` or `"'true'"`. Since this is a very important setting, not sure why no one is raising this up.

All other cors settings work without problem, just `AllowCredentials`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.