aws / aws/aws-pdk

[BUG] graph plugin does not respect per-diagram FilterPlan config

Open
#649 3 comments 1 reaction 0 assignees View on GitHub
backlog bug
Dominant language
TypeScript
Stars
451
Forks
84
Avg merge
20h 3m
Merged PRs (30d)
1

Description

### Describe the bug

using this code (Python)
```python
graph = CdkGraph(
app,
plugins=[
cast(
ICdkGraphPlugin,
CdkGraphDiagramPlugin(
diagrams=[
{
"title": "unfiltered",
"name": "unfiltered",
"filter_plan": {
"preset": FilterPreset.NONE,
},
},
{
"title": "non-extraneous",
"name": "non-extraneous",
"filter_plan": {
"preset": FilterPreset.NON_EXTRANEOUS,
},
},
{
"title": "compact",
"name": "compact",
"filter_plan": {
"preset": FilterPreset.COMPACT,
},
},
]
),
)
],
)
```

...when I run this I get three files all output using the `FilterPreset.COMPACT` style

### Expected Behavior

each diagram output should respect its own FilterPlan config

### Current Behavior

all the files come out in `FilterPreset.COMPACT` style (maybe last-defined wins?)

### Reproduction Steps

see above

### Possible Solution

_No response_

### Additional Information/Context

_No response_

### PDK version used

0.22.41

### What languages are you seeing this issue on?

Python

### Environment details (OS name and version, etc.)

macOS 14.1

Contributor guide

Open the contributing guide

Research direction

Start at CdkGraph and CdkGraphDiagramPlugin and reproduce the three-diagram example from the issue. Trace how each diagram's filter_plan is passed and applied, then verify that the unfiltered, non-extraneous, and compact outputs each use their own preset.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, typescript
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.