aws / aws/aws-node-termination-handler

Group and queue nodes for termination

Open
#576 10 comments 1 reaction 0 assignees View on GitHub
stalebot-ignore Type: Enhancement
Dominant language
Go
Stars
1.8k
Forks
286
PR merge metrics
No merged PRs in 30d

Description

**Describe the feature**
I'd like NTH to be able to group nodes (similar to the CA `--balance-similar-node-groups`) and support processing `n` nodes per group (this can still be constrained by the workers configuration).

I assume that v2 would be designed around this kind of concept, but I think it'd be worth doing in v1 assuming it wouldn't take too much effort.

**Is the feature request related to a problem?**
When using NTH to manage ASG instance refresh events it is very easy to get a cluster into a blocking race condition due to pods being terminated off different nodes causing no nodes to be able to fully shut down due to PDBs. This results in hard terminations and general cluster instability.

**Describe alternatives you've considered**
Using a single worker would work but it would be to slow to respond to time critical events and even for instance refresh it could be too slow for good usability.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.