aws / aws/aws-lambda-go

Need access to NoEcho on cfn.Response via LambdaWrap

Open
#215 0 comments 0 reactions 0 assignees View on GitHub
enhancement type/cfn
Dominant language
Go
Stars
3.8k
Forks
578
Avg merge
8h 18m
Merged PRs (30d)
1

Description

**Is your feature request related to a problem? Please describe.**

The `cfn.LambdaWrap` convenience method is very useful for creating the `cfn.Response` that is written back to the cloudformation s3 bucket. Unfortunately, there doesn't seem to be a way of setting the NoEcho bool on the `cfn.Response` when using `cfn.LambdaWrap`.

**Describe the solution you'd like**
Perhaps adding a `noEcho` bool to the returned tuple from the `CustomResourceFunction`, and then checking for that value in `lambdaWrapWithClient`. Not ideal because that is a breaking change.

Another option would be to have `CustomResourceFunction` return a Response object, instead of a tuple with the physicalResourceId and the data map. That would allow the user to populate Data,PhysicalResourceId, and NoEcho themselves, and have the boilerplate fill in the required values after. Again, this would be a breaking change.

The 2 options above would work with new function definitions of `LambdaWrap`, in order to maintain backwards compatibility.

**Describe alternatives you've considered**
The current work around is to copy the boilerplate code, and craft the Response myself.

**Additional context**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.