aws / aws/aws-lambda-builders

Missing -mod=${VENDOR_PATH} support for go build

Open
#165 0 comments 1 reaction 0 assignees View on GitHub
area/workflow/go_modules maintainer/need-response type/feature
Dominant language
Python
Stars
380
Forks
161
Avg merge
1d 1h
Merged PRs (30d)
2

Description

**Description:**
Missing `-mod=${VENDOR_PATH}` support for go build. This prevent the use of external private repositories eventually pushed inside the repository

**Steps to reproduce the issue:**
1. Declare under `go.mod` a private repository
2. `sam build`

**Observed result:**
```
Build Failed
Error: GoModulesBuilder:Build - Builder Failed: go: ... unknown revision ...
```

**Expected result:**
Build without error like `env GOOS=linux ARCH=amd64 go build -mod=${VENDOR_PATH} -o ${OUTPUT_PATH} ${TARGET}`

**Additional environment details (Ex: Windows, Mac, Amazon Linux etc)**
No additional environment details

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.