aws / aws/aws-js-sns-message-validator

wish: If no callback is supplied return a Promise

Open
#20 11 comments 9 reactions 0 assignees View on GitHub
feature-request
Dominant language
JavaScript
Stars
74
Forks
38
PR merge metrics
No merged PRs in 30d

Description

Node.js Now has some Promise methods in the core as well as `async` and `await`.

Having `validate` return a promise if no callback is provided would a welcome addition.

Bluebird's `asCallback()` method as one of example of supporting both callback and Promise APIs.

http://bluebirdjs.com/docs/api/ascallback.html

Contributor guide

Open the contributing guide

Research direction

Start at the `validate` API and inspect how it currently handles callback arguments. Add coverage for calling `validate` without a callback and verify that it returns a Promise while the existing callback behavior remains supported.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.