aws / aws/aws-encryption-sdk-javascript

@aws-crypto/client-browser Buffer usage in raw2der causing ReferenceError when decrypting

Open
#1,050 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
260
Forks
68
Avg merge
22h 19m
Merged PRs (30d)
2

Description

### Problem:
When using @aws-crypto/client-browser version 3.1.1, calling `decrypt()` will result in a `ReferenceError`. `decrypt` calls `raw2der`, which includes a reference to global `Buffer` type. The `buffer` npm package is not listed as a dependency in the package.json.

### Solution:
Either decouple the browser and node `ecdsa_signature.ts` helpers and use a `Uint8Array` instance instead of `Buffer` or add the [buffer](https://www.npmjs.com/package/buffer) dependency to the package.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.