aws / aws/aws-encryption-sdk-c

Expose which_sha implementation to avoid duplicated in CBMC

Open
#666 0 comments 0 reactions 0 assignees View on GitHub
cbmc
Dominant language
C
Stars
63
Forks
59
PR merge metrics
No merged PRs in 30d

Description

The `which_sha` function is static so it was copied to [make_common_data_structures.c](https://github.com/aws/aws-encryption-sdk-c/blob/master/verification/cbmc/sources/make_common_data_structures.c). In #638 this was updated and we discussed the possibility of exposing it to avoid duplication.

Contributor guide

Open the contributing guide

Research direction

Start by locating the static which_sha definition and comparing it with verification/cbmc/sources/make_common_data_structures.c. Review the discussion in #638, then verify that the CBMC sources use the exposed implementation without duplicated logic and that verification still builds.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cryptography, testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.