aws / aws/aws-encryption-sdk-c

KMS tests extremely slow in Mac OS build

Open
#575 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
63
Forks
59
PR merge metrics
No merged PRs in 30d

Description

e.g (from https://github.com/aws/aws-encryption-sdk-c/pull/574/checks?check_run_id=977613014)

```
Start 2: t_kms_keyring.test
2/22 Test #2: t_kms_keyring.test ............... Passed 484.45 sec
```

That test takes less than a second on my laptop. Wat.

(Was "KMS tests are spuriously passing in Mac OS build" - this was is a false alarm: `t_kms_keyring.test` mocks out the KMS client and does not need AWS credentials. I was misled by the superficially realistic-looking CMK ARN in the test code. :) Original description below:

The GitHub Actions-based build (.github/workflows/osx.yml) does not provide any AWS credentials, so it should not be possible for any tests that depend on KMS to work.

They are likely passing because the tests are accidentally ignoring error return values at some point.

Contributor guide

Open the contributing guide

Research direction

Start with .github/workflows/osx.yml and the t_kms_keyring.test target, then compare the macOS test invocation with the local run described in the issue. Determine why the test takes about 484 seconds in the build and confirm that the relevant KMS test completes promptly without requiring AWS credentials.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, github-actions
Domain
ci-cd, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.