aws / aws/aws-encryption-sdk-c
Clean up warnings in Windows build
- Dominant language
- C
- Stars
- 63
- Forks
- 59
- PR merge metrics
- No merged PRs in 30d
Description
```[71/101] Building C object tests\CMakeFiles\test_local_cache_threading.dir\integration\t_local_cache_threading.c.obj
..\tests\integration\t_local_cache_threading.c(85): warning C4244: 'return': conversion from 'uint64_t' to 'unsigned long', possible loss of data
..\tests\integration\t_local_cache_threading.c(116): warning C4113: 'unsigned long (__cdecl *)()' differs in parameter lists from 'unsigned long (__cdecl *)(void)'
Contributor guide
Research direction
Start with tests/integration/t_local_cache_threading.c at lines 85 and 116, then reproduce the Windows build that reports the warnings. Inspect the types and function signature at those locations, and consider the work done when the Windows build no longer emits C4244 or C4113 for this test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- build-system, testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100