aws / aws/aws-cli

symlinks are evaluated before exclude\include - "File does not exist"

Open
#7,072 3 comments 0 reactions 0 assignees View on GitHub
bug p3 s3 s3filters s3sync
Dominant language
Python
Stars
17.3k
Forks
4.6k
Avg merge
1d 2h
Merged PRs (30d)
13

Description

### Describe the bug

```aws s3 sync . s3:\\my_bucket --exclude "*" --include "package*" ```

if there is a symlink in the source directory that is linked to a missing file - the command will throw a "File does not exist" warning, even though the symlink name does not match the filters applied to the command (i.e does not start with "package")

### Expected Behavior

ignore non matching symlinks names, and suppress related warnings \ errors

### Current Behavior

symlinks that are missing but do not match command filters still throw warnings

### Reproduction Steps

1. create a symlink to a non existing file
2. sync parent directory to an s3 bucket while excluding the symlink from step 1

### Possible Solution

_No response_

### Additional Information/Context

_No response_

### CLI version used

2.5.2

### Environment details (OS name and version, etc.)

Linux/5.10.104-linuxkit (docker image: node:16.14.0-bullseye-slim)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.