aws / aws/aws-cli

should pyasn1 and jmespath be added to configuration files?

Open
#6,556 2 comments 0 reactions 1 assignee Claimed by @kdaily View on GitHub
dependencies feature-request installation p3
Dominant language
Python
Stars
17.3k
Forks
4.6k
Avg merge
1d 2h
Merged PRs (30d)
13

Description

**Describe the question**
Hi
I notice that pyasn1 and jmespath are missing in configuration files. They are used in source code but not declared.

- pyasn1
https://github.com/aws/aws-cli/blob/6ad60664366773b00970bbee12bc0b68c839a439/awscli/customizations/cloudtrail/validation.py#L25

- jmespath
for example
https://github.com/aws/aws-cli/blob/45b0063b2d0b245b17a57fd9eebd9fcc87c4426a/awscli/customizations/arguments.py#L16

If the dependency is used in code, it should be declared.

**Expected Behavior**
So it it necessary to add them to configuration files such as requirement-*.txt?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.